Skip to content

Conversation

@tboulogne
Copy link
Contributor

For now, could not use django-instant behind a proxy without redirecting centrifugo port.

With this parameter, if CENTRIFUGO_PROXY is True in application.settings, CENTRIFUGO_PORT will be removed from CENTRIFUGO_URL.

Upstream server (example for Nginx will manage port redirection)

CENTRIFUGO_PROXY default is False

to use django-instant behind a proxy
@coveralls
Copy link

coveralls commented Sep 30, 2018

Pull Request Test Coverage Report for Build 173

  • 5 of 9 (55.56%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 47.792%

Changes Missing Coverage Covered Lines Changed/Added Lines %
instant/producers.py 0 2 0.0%
instant/templatetags/instant_tags.py 4 6 66.67%
Totals Coverage Status
Change from base Build 157: -0.04%
Covered Lines: 232
Relevant Lines: 466

💛 - Coveralls

@synw
Copy link
Owner

synw commented Sep 30, 2018

Ok for this. Just a little thing: please use a if CENTRIFUGO_PROXY is True check instead of if CENTRIFUGO_PROXY: its faster. Then I'll merge this

@tboulogne
Copy link
Contributor Author

Ok for this. Just a little thing: please use a if CENTRIFUGO_PROXY is True check instead of if CENTRIFUGO_PROXY: its faster. Then I'll merge this

Done.

@synw synw merged commit 4c0b718 into synw:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants