Merged
Conversation
Collaborator
|
I got this error when I ran it on biomodel 36. The annotating part ran fine, but it got to the creating table part then closed. 
|
Collaborator
Author
|
I believe the AMAS settings you used to generate that had ABOVE selected as the MSSC setting? |
Collaborator
Author
Yeah I get this same error when using the ABOVE option on the currently deployed branch as well |
Collaborator
Author
|
Just tested it on Kevin's older branches and same behavior on that ABOVE option for MSSC. |
Comment on lines
295
to
301
| setStep(3); | ||
| setGenInProgress(false); | ||
| } catch (error) { | ||
| console.error("Unable to generate annotation recommendations:", error); | ||
| setGenInProgress(false); | ||
| onClose(); | ||
| } |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Changes of the implementation of the AMAS algorithm as described in #65
Also fixes an issue with actually applying the annotations to a file due to no longer only having the IndexDB only open as version 1,
You can check a side by side of the changed algorithm in
\AntimonyEditor\src\libs\AMAS-js\src\reaction_annotation.jsTesting
Code runs and builds
Expected Behavior: