Zero client password key material after use#38
Merged
Conversation
Ensure non-login password flows and transient KDF outputs wipe raw byte arrays once ownership ends, reducing client memory exposure without changing auth or vault semantics. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Follow-up to the Nightglass audit finding posted on PR #11 about non-login password flows leaving raw PBKDF2 master bytes uncleared.
Test plan
source ~/.nvm/nvm.sh && nvm use 22.17.1 && CI=true npm test -- --watchAll=false --runInBand src/lib/crypto/kdf.test.js src/lib/authService.test.js src/context/VaultContext.test.js src/components/ChangePasswordCard.test.js src/components/DeleteAccountCard.test.jssource ~/.nvm/nvm.sh && nvm use 22.17.1 && CI=true npm test -- --watchAll=false --runInBandsource ~/.nvm/nvm.sh && nvm use 22.17.1 && npm run buildsource ~/.nvm/nvm.sh && nvm use 22.17.1 && npm audit --omit=devMade with Cursor