Skip to content

Conversation

@IgorEulalio
Copy link
Contributor

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x ] Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • [ x ] Chart Version bumped for the respective charts
  • [ x ] Variables are documented in the README.md (or README.tpl in some charts)
  • [ x ] Check GithubAction checks (like lint) to avoid merge-check stoppers
  • [ x ] All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@IgorEulalio IgorEulalio requested review from a team as code owners December 5, 2023 12:53
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@IgorEulalio IgorEulalio changed the title Feat/add verify registry as option in values feat(cluster-scanner): add verify registry as option in values Dec 5, 2023
@github-actions github-actions bot dismissed their stale review December 5, 2023 12:53

All good!

@IgorEulalio IgorEulalio enabled auto-merge (squash) December 5, 2023 14:19
@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Dec 5, 2023
@IgorEulalio IgorEulalio merged commit 4d5254f into master Dec 5, 2023
@IgorEulalio IgorEulalio deleted the feat/add-verify-registry-as-option-in-values branch December 5, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-tests Chart templates modified without test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants