Skip to content

Conversation

@e-minguez
Copy link
Contributor

@e-minguez e-minguez commented Jun 23, 2022

A first try to have a github action. See the results of a successful run here https://github.com/e-minguez/test-gha/runs/7132759775?check_suite_focus=true

@manuelbcd manuelbcd requested a review from guipal June 23, 2022 16:27
@manuelbcd
Copy link
Contributor

LGTM
I'm adding @guipal

@manuelbcd manuelbcd self-requested a review June 23, 2022 16:30
@e-minguez
Copy link
Contributor Author

@airadier would you mind to take a look? Thanks!

@e-minguez
Copy link
Contributor Author

Is there anything else needed for this to be merged? Thanks

@airadier
Copy link
Collaborator

Is there anything else needed for this to be merged? Thanks

Is there anything else needed for this to be merged? Thanks

Not really, but for the sake of simplicity I would suggest keeping the example minimal or complete the pending items (enable cache). What do you think?

@e-minguez
Copy link
Contributor Author

Is there anything else needed for this to be merged? Thanks

Is there anything else needed for this to be merged? Thanks

Not really, but for the sake of simplicity I would suggest keeping the example minimal or complete the pending items (enable cache). What do you think?

ACK. I wanted to have something quick and then add the cache feature later on but I guess it would be better to have it at once. I'll ping you again when I submit the new changes. Thanks.

@e-minguez
Copy link
Contributor Author

I've added support for the github actions cache. See a successful run here https://github.com/e-minguez/test-gha/runs/7132759775?check_suite_focus=true

@airadier
Copy link
Collaborator

I've added support for the github actions cache. See a successful run here https://github.com/e-minguez/test-gha/runs/7132759775?check_suite_focus=true

Amazing work! Thanks!

@airadier airadier merged commit 38b0297 into sysdiglabs:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants