-
Notifications
You must be signed in to change notification settings - Fork 24
Added Azure pipelines example #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@airadier @manuelbcd PTAL Thanks |
airadier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much, this is lovely. Two_ minor things:
- Can we move the examples inside the new-scan-engine folder? We are trying to reorganize the repository so we keep legacy and new engine examples under different folders
- In the index.md file state clearly that the example is for the new engine.
701bb09 to
53f9e73
Compare
🤣
Addressed, thanks.
Addressed, thanks. PTAL and thanks for the feedback! |
airadier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion and noise, let's align on this with @manuelbcd because I see we have a:
/new-scan-engine/aws-codebuild
with an example for aws-codebuild. Then for gitlab, we have:
/gitlab/old-scan-engine
/gitlab/new-scan-engine
which follows this patterm. Which one we should choose and stick with? Make the /new-scan-engine at the root level and put examples inside, or make the split at the integration level?
I am ok with the current approach (just see my minimal change proposal) and we make the refactor later if needed.
Co-authored-by: Álvaro Iradier <airadier@gmail.com>
My 2 cents on this is to have them splitted by the provider: |
|
Thanks @e-minguez , but just a minor change in the folder names to align with the current ones: instead of "scanning" we are using "scan" thanks! |
I cannot create a public project in my Azure account so you can see if it works (IDK why) but it worked :)