Skip to content

Conversation

@e-minguez
Copy link
Contributor

I cannot create a public project in my Azure account so you can see if it works (IDK why) but it worked :)

image

@e-minguez
Copy link
Contributor Author

@airadier @manuelbcd PTAL Thanks

Copy link
Collaborator

@airadier airadier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much, this is lovely. Two_ minor things:

  • Can we move the examples inside the new-scan-engine folder? We are trying to reorganize the repository so we keep legacy and new engine examples under different folders
  • In the index.md file state clearly that the example is for the new engine.

@e-minguez
Copy link
Contributor Author

e-minguez commented Sep 2, 2022

Thanks very much, this is lovely

🤣

. Two_ minor things:

  • Can we move the examples inside the new-scan-engine folder? We are trying to reorganize the repository so we keep legacy and new engine examples under different folders

Addressed, thanks.

  • In the index.md file state clearly that the example is for the new engine.

Addressed, thanks.

PTAL and thanks for the feedback!

Copy link
Collaborator

@airadier airadier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion and noise, let's align on this with @manuelbcd because I see we have a:

/new-scan-engine/aws-codebuild

with an example for aws-codebuild. Then for gitlab, we have:

/gitlab/old-scan-engine
/gitlab/new-scan-engine

which follows this patterm. Which one we should choose and stick with? Make the /new-scan-engine at the root level and put examples inside, or make the split at the integration level?

I am ok with the current approach (just see my minimal change proposal) and we make the refactor later if needed.

Co-authored-by: Álvaro Iradier <airadier@gmail.com>
@e-minguez
Copy link
Contributor Author

Sorry for the confusion and noise, let's align on this with @manuelbcd because I see we have a:

/new-scan-engine/aws-codebuild

with an example for aws-codebuild. Then for gitlab, we have:

/gitlab/old-scan-engine /gitlab/new-scan-engine

which follows this patterm. Which one we should choose and stick with? Make the /new-scan-engine at the root level and put examples inside, or make the split at the integration level?

I am ok with the current approach (just see my minimal change proposal) and we make the refactor later if needed.

My 2 cents on this is to have them splitted by the provider:

GitHub/
|-- new-scanner-engine
`-- old-scanner-engine
GitLab/
|-- new-scanner-engine
`-- old-scanner-engine

@manuelbcd
Copy link
Contributor

manuelbcd commented Sep 2, 2022

Thanks @e-minguez , but just a minor change in the folder names to align with the current ones: instead of "scanning" we are using "scan"

GitHub/
|-- new-scan-engine
`-- old-scan-engine
GitLab/
|-- new-scan-engine
`-- old-scan-engine

thanks!

@manuelbcd manuelbcd self-requested a review September 2, 2022 11:06
@manuelbcd manuelbcd merged commit 4d2e46b into sysdiglabs:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants