Skip to content

Removing digest based scan result call #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davideschiera merged 2 commits into from
Nov 25, 2019
Merged

Removing digest based scan result call #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4802bdc
Removing digest based scan result call
haresh-suresh Nov 20, 2019
39c7596
Merge branch 'master' of https://github.com/draios/python-sdc-client …
haresh-suresh Nov 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions sdcclient/_scanning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,25 +371,6 @@ def get_image_scan_result_by_id(self, image_id, full_tag_name):

return [True, res.json()]

def get_image_info_by_id(self, image_id_sha):
'''**Description**
Get the anchore image info for an image id sha.

**Arguments**
- image_id: Image id sha of the image.

**Success Return Value**
A JSON object containing metadata about the image.
'''
url = "{base_url}/api/scanning/v1/anchore/images/{image_id_sha}".format(
base_url=self.url,
image_id_sha=image_id_sha)
res = requests.get(url, headers=self.hdrs, verify=self.ssl_verify)
if not self._checkResponse(res):
return [False, self.lasterr]

return [True, res.json()]

def add_registry(self, registry, registry_user, registry_pass, insecure=False, registry_type="docker_v2", validate=True):
'''**Description**
Add image registry
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from setuptools import setup

setup(name='sdcclient',
version='0.10.0-dev',
version='0.10.1-dev',
Copy link
Contributor

@davideschiera davideschiera Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, how do you "use" this change?

Copy link
Contributor

@marojor marojor Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI has a requirement on sdcclient. I guess that's the reason for the update

description='Python client for Sysdig Cloud',
url='http://github.com/draios/python-sdc-client',
author='sysdig Inc.',
Expand Down