Skip to content

Conversation

@philrz
Copy link
Contributor

@philrz philrz commented Feb 7, 2018

Previously, examples/user_team_mgmt.py was passing ok even though the customer account it points to had reached its max Teams count. I've changed the example to genuinely fail with a proper exit code in these situations, and also have increased the Teams count on the relevant customer account so it should pass legit. While I was at it, I made it fail in more of the other cases as well, since as long as the test environment is healthy (e.g. Team of the same name was properly deleted at the end of any prior test) it should always pass.

@philrz philrz requested a review from mstemm February 7, 2018 20:30
Copy link
Contributor

@mstemm mstemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, thanks!

@philrz philrz merged commit 4dc67f7 into master Feb 7, 2018
@philrz philrz deleted the improve-teams-example branch February 7, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants