[pull] master from gradle:master#135
Merged
pull[bot] merged 3 commits intosysfce2:masterfrom Sep 5, 2025
Merged
Conversation
After #33925, we follow up with some refactorings. Most importantly, we clean up visitOutgoingDependencies and excludesSameDependenciesAsPreviousTraversal, which were two very coupled methods. excludesSameDependenciesAsPreviousTraversal performed side-effects which anticipated what visitOutgoingDependencies would do with its return value. This sort of coupling is confusing to follow and maintain. We inline and refactor some logic to make the logic easier to follow and maintain.
In some instance when visiting a node's dependencies, if we've already visited that node's dependencies, we short-circuit and only visit a subset of dependencies. However, when visiting this subset we used the old exclusion filter, even if it changes. This commit ensures we use the most up-to-date and correct resolution filter when visiting this subset of dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )