[pull] master from ruby:master#116
Merged
pull[bot] merged 2 commits intosysfce2:masterfrom Jan 4, 2026
Merged
Conversation
I started the work to address #1537, but I think we should just go with the GH markdown style anchor/link generation in the future. Anchors Generated: | Context | Before | After | |---------|--------|-------| | Heading `== Hello` (standalone) | `id="label-Hello"` | `id="hello"` | | Heading `== Hello` (in class Foo) | `id="class-Foo-label-Hello"` | `id="class-foo-hello"` | | Heading `== Hello` (in method #bar) | `id="method-i-bar-label-Hello"` | `id="method-i-bar-hello"` | | Class/Module anchor | `id="class-Foo::Bar"` | `id="class-foo-bar"` | **Legacy anchors preserved as hidden `<span class="legacy-anchor">` elements. So links targeting old anchors should still work.** Links Generated: | Syntax | Before | After | |--------|--------|-------| | `rdoc-ref:@foo` | `href="#label-foo"` | `href="#foo"` | | `rdoc-ref:Class@foo` | `href="#class-Class-label-foo"` | `href="#class-class-foo"` | | `rdoc-ref:Class#method@foo` | `href="#method-i-method-label-foo"` | `href="#method-i-method-foo"` | | `rdoc-ref:Class@Section Title` | `href="#Section Title"` | `href="#section-title"` | These changes now enable Markdown links to work with GitHub-style anchors. Markdown `[link](#foo)` passes through unchanged as `href="#foo"`. - Before: Anchor was `id="label-Foo"` -> link broken - After: Anchor is `id="foo"` -> link works Supportive Changes: - ToC sidebar links updated to use new anchor format Closes #1537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )