Merged
Conversation
https://bugs.webkit.org/show_bug.cgi?id=283421 rdar://139305520 Reviewed by Ryosuke Niwa and BJ Burg. Add User Agent string overrides for browsers on Android. * Source/WebInspectorUI/UserInterface/Views/OverrideDeviceSettingsPopover.js: (WI.OverrideDeviceSettingsPopover.prototype._createUserAgentSection): Canonical link: https://commits.webkit.org/287092@main
https://bugs.webkit.org/show_bug.cgi?id=283711 Reviewed by Adrian Perez de Castro. Use stdlib features instead of C arrays and raw pointer arithmetic. * Source/WebCore/platform/xdg/MIMETypeRegistryXdg.cpp: (WebCore::MIMETypeRegistry::preferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::extensionsForMIMEType): Canonical link: https://commits.webkit.org/287093@main
https://bugs.webkit.org/show_bug.cgi?id=283573 Reviewed by Carlos Alberto Lopez Perez. If you use an external SD card reader, the device path looks like /dev/sde. The second partition is numbered /dev/sde2, not /dev/sdep2. Update the deployment script to handle this case. * Tools/yocto/deploy_image_scripts/wic-to-sdcard.sh: Canonical link: https://commits.webkit.org/287094@main
…ntainer https://bugs.webkit.org/show_bug.cgi?id=283694 Reviewed by Antti Koivisto. RubyFormattingContext::applyRubyAlignOnBaseContent assumes base content is not breakable and expects to see a base end boundary in the line run list. This assumption leads to computing incorrect base content width (logical left of the run _after_ the base end) which results in incorrect alignment (i.e. base content is computed to be smaller than what it really is which means extra distributable space). * LayoutTests/fast/ruby/ruby-base-with-breakable-content-inside-expected.html: Added. * LayoutTests/fast/ruby/ruby-base-with-breakable-content-inside.html: Added. * Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp: (WebCore::Layout::RubyFormattingContext::applyRubyAlignOnBaseContent): (Kusa-Makura-background-canvas shows progression) Canonical link: https://commits.webkit.org/287095@main
…erExpectations https://bugs.webkit.org/show_bug.cgi?id=283712 Reviewed by Youenn Fablet. I missed that 287091@main would address this. * Source/WebCore/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations: Canonical link: https://commits.webkit.org/287096@main
https://bugs.webkit.org/show_bug.cgi?id=283717 Reviewed by Youenn Fablet. PDFPluginBase::navigateToURL uses the FrameLoader API. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: Canonical link: https://commits.webkit.org/287097@main
https://bugs.webkit.org/show_bug.cgi?id=283714 rdar://140580406 Reviewed by Alan Baradlay. Use iterator to paint SVG text. * Source/WebCore/layout/integration/inline/InlineIteratorBox.cpp: (WebCore::InlineIterator::BoxIterator::traverseNextOnLine): (WebCore::InlineIterator::BoxIterator::traverseNextOnLineSkippingChildren): Add support for unconstrained tree-order traversal. (WebCore::InlineIterator::LeafBoxIterator::traverseNextOnLine): (WebCore::InlineIterator::LeafBoxIterator::traversePreviousOnLine): * Source/WebCore/layout/integration/inline/InlineIteratorBox.h: (WebCore::InlineIterator::BoxIterator::BoxIterator): (WebCore::InlineIterator::BoxIterator::operator++): (WebCore::InlineIterator::LeafBoxIterator::operator++): * Source/WebCore/layout/integration/inline/InlineIteratorBoxLegacyPath.h: (WebCore::InlineIterator::BoxLegacyPath::traverseNextLeafOnLine): (WebCore::InlineIterator::BoxLegacyPath::traversePreviousLeafOnLine): (WebCore::InlineIterator::BoxLegacyPath::traverseNextBoxOnLine): (WebCore::InlineIterator::BoxLegacyPath::traverseNextBoxOnLineSkippingChildren): (WebCore::InlineIterator::BoxLegacyPath::traverseNextOnLine): Deleted. (WebCore::InlineIterator::BoxLegacyPath::traversePreviousOnLine): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h: (WebCore::InlineIterator::BoxModernPath::traverseNextLeafOnLine): (WebCore::InlineIterator::BoxModernPath::traversePreviousLeafOnLine): (WebCore::InlineIterator::BoxModernPath::traverseNextBoxOnLine): (WebCore::InlineIterator::BoxModernPath::traverseNextBoxOnLineSkippingChildren): (WebCore::InlineIterator::BoxModernPath::firstLeafBoxForInlineBox const): (WebCore::InlineIterator::BoxModernPath::lastLeafBoxForInlineBox const): (WebCore::InlineIterator::BoxModernPath::traverseNextOnLine): Deleted. (WebCore::InlineIterator::BoxModernPath::traversePreviousOnLine): Deleted. * Source/WebCore/layout/integration/inline/InlineIteratorLineBoxModernPath.h: (WebCore::InlineIterator::LineBoxIteratorModernPath::firstLeafBox const): (WebCore::InlineIterator::LineBoxIteratorModernPath::lastLeafBox const): * Source/WebCore/layout/integration/inline/InlineIteratorSVGTextBox.cpp: (WebCore::InlineIterator::boxesFor): * Source/WebCore/layout/integration/inline/InlineIteratorSVGTextBox.h: (WebCore::InlineIterator::SVGTextBoxRange::SVGTextBoxRange): Deleted. (WebCore::InlineIterator::SVGTextBoxRange::begin const): Deleted. (WebCore::InlineIterator::SVGTextBoxRange::end const): Deleted. * Source/WebCore/rendering/LegacyInlineBox.h: * Source/WebCore/rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::paint): Deleted. * Source/WebCore/rendering/LegacyInlineFlowBox.h: * Source/WebCore/rendering/LegacyInlineTextBox.cpp: (WebCore::LegacyInlineTextBox::paint): Deleted. * Source/WebCore/rendering/LegacyInlineTextBox.h: * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::paintInlineChildren): * Source/WebCore/rendering/RenderInline.cpp: (WebCore::RenderInline::paint): * Source/WebCore/rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint const): Deleted. * Source/WebCore/rendering/RenderLineBoxList.h: * Source/WebCore/rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::paintInlineChildren): Use iterator to paint SVG text boxes with SVGTextBoxPainter. * Source/WebCore/rendering/svg/RenderSVGText.h: * Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paintSelectionBackground): Deleted. (WebCore::SVGInlineFlowBox::paint): Deleted. * Source/WebCore/rendering/svg/SVGInlineFlowBox.h: * Source/WebCore/rendering/svg/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::paintSelectionBackground): Deleted. (WebCore::SVGInlineTextBox::paint): Deleted. * Source/WebCore/rendering/svg/SVGInlineTextBox.h: * Source/WebCore/rendering/svg/SVGRenderingContext.cpp: (WebCore::SVGRenderingContext::SVGRenderingContext): Add a move constructor so these work correctly when pushed into a Vector. * Source/WebCore/rendering/svg/SVGRenderingContext.h: (WebCore::SVGRenderingContext::renderer const): * Source/WebCore/rendering/svg/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint): Deleted. * Source/WebCore/rendering/svg/SVGRootInlineBox.h: Canonical link: https://commits.webkit.org/287098@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )