Rollback test_binlog_reader-t.cpp to tag v3.0.5

[renecannao]

The test_binlog_reader-t.cpp test was previously modified to attempt fixing issues in the new CI infrastructure. However, these fixes depended on the 'proxysql_mysqlbinlog' tool which is currently missing or not correctly provisioned in the new environment.

As the previous attempts to workaround the missing tool by dynamically detecting hostgroups and enabling GTID ports did not lead to a passing test, we are rolling back this file to its known stable state from tag v3.0.5. This aligns with the requirement to maintain test integrity while the infrastructure provisioning for the binlog reader tool is addressed.

Summary by CodeRabbit

• Chores
  • Improved test infrastructure by removing diagnostic logging and streamlining connection initialization logic in the binlog reader test suite.
  • Corrected comparison logic in test validation to ensure consistent value orientation checks.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts changes made to the test_binlog_reader-t.cpp file, restoring it to a known stable version from tag v3.0.5. This rollback is necessary because previous attempts to fix CI infrastructure issues related to a missing proxysql_mysqlbinlog tool were unsuccessful and introduced dependencies that could not be met in the new environment, ensuring test integrity while infrastructure provisioning is resolved.

Highlights

• Test File Rollback: The test_binlog_reader-t.cpp file has been reverted to its known stable state from tag v3.0.5.
• CI Infrastructure Fixes: This rollback addresses issues in the new CI infrastructure where previous fixes depended on a missing or incorrectly provisioned proxysql_mysqlbinlog tool.
• Code Cleanup: Removed several diag() logging calls and associated user provisioning logic that were part of the unsuccessful attempts to fix the CI issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• test/tap/tests/test_binlog_reader-t.cpp
  • Removed the <numeric> header inclusion.
  • Eliminated several diag() logging statements from various functions.
  • Refactored the connection initialization sequence for ProxySQL MySQL and Admin clients.
  • Removed the logic responsible for ensuring the 'sbtest8' user exists and loading MySQL users to runtime.
  • Adjusted the order of operands in a boolean comparison for hg_1200_checks.

Activity

• No human activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 14433de9-6c19-41cf-8ee9-5388d1a200d7

📥 Commits

Reviewing files that changed from the base of the PR and between 9d921bd and b4687da.

📒 Files selected for processing (1)

• test/tap/tests/test_binlog_reader-t.cpp

---

📝 Walkthrough

Walkthrough

Test file cleanup that removes diagnostic logging calls, simplifies initialization and connection logic in the main function, and corrects a comparison logic error in the check_gitd_tracking function where expected and actual query values are now compared in consistent orientation.

Changes

Cohort / File(s)	Summary
Test Cleanup & Logic Correction test/tap/tests/test_binlog_reader-t.cpp	Removed diagnostic calls throughout the file; streamlined main function's initialization and connection setup; eliminated runtime user provisioning steps; corrected check_gitd_tracking comparison from act_queries == exp_queries to exp_queries == act_queries for consistent value orientation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A test run cleaned of chatter and noise,
Diagnostics trimmed away like old toys,
Comparisons flipped to make logic true,
Simpler and cleaner, the test shines anew!

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch v3.0-test_binlog_reader_2602

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request rolls back test/tap/tests/test_binlog_reader-t.cpp to a previous stable version from tag v3.0.5. The changes are consistent with a rollback, primarily removing recent additions like diagnostic logging and logic related to CI fixes.

My review found one minor issue: the <numeric> header is removed, but the file still uses std::accumulate. While this might compile due to transitive includes from other headers (like json.hpp), it's best practice to explicitly include headers for symbols used directly in a file to improve maintainability and prevent future build breaks. I've added a suggestion to restore the include. Otherwise, the rollback appears correct.

_{Note: Security Review did not run due to the size of the PR.}

[gemini-code-assist]

The <numeric> header was removed, but std::accumulate (which is defined in <numeric>) is used later in this file (line 326). While this may compile due to being included transitively through another header (e.g., json.hpp), it's best practice to include headers for all symbols directly used in a file. This improves code clarity and prevents potential build failures if transitive dependencies change in the future. Please restore this include.

Suggested change

	#include <numeric>