Conversation
This enables Ruff static analysis across all installable modules with pyproject.toml configuration. Convert .format() calls to f-strings, modernize exception handling (EnvironmentError/IOError -> OSError, bare except -> except Exception, class Foo(object) -> class Foo, super(Cls, self) -> super()), and fix a pre-existing bug where the option-env warning had its arguments swapped. Rule coverage: F, E, W, UP, B, A, PLE, PLW, PLR1714/1730/0402, BLE, S102/S110/S301/S307/S602, SIM115. Intentional patterns suppressed via scoped per-file-ignores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates Ruff as static analysis linter alongside the existing black formatter. The pyproject.toml configures targeted rule categories (Pyflakes, pycodestyle, pyupgrade, flake8-bugbear, flake8-builtins, and select pylint rules) with per-file ignores for structural patterns like tkinter wildcard imports and module-level globals in TUI/GUI code.
Code fixes applied across all three source files:
Close #11
Summary by cubic
Add Ruff linter with CI enforcement and project config. Cleaned up code to satisfy lint rules, fixed cached-node state leakage in TUI/GUI search, and corrected the option-env warning message arguments.
Refactors
Bug Fixes
Written for commit 460ab77. Summary will update on new commits.