Align menuconfig key bindings and popup rendering#45
Merged
Conversation
Key binding changes to match lxdialog/menubox.c: - S sets YES (was save shortcut, no C equivalent) - H/? shows help (was vi-style leave-menu) - Remove vi navigation keys j/k/l/g/G (free for hotkey search) - Remove Python-only shortcuts o (load) and d (save-minimal) - Merge e/x/ESC/Backspace into single leave-menu handler - Quit dialog uses 2 buttons (Yes/No) matching C dialog_yesno Popup border visibility fix: - Use body_style for all popup box edges (the C bold-white-on-white convention relies on ncurses ACS rendering that raw terminal output cannot replicate, making left/top borders invisible) - Extract _draw_title, _draw_separator helpers to eliminate duplication - Clamp text/button positions to protect border characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key binding changes to match lxdialog/menubox.c:
Popup border visibility fix:
Summary by cubic
Aligns menuconfig key bindings with lxdialog and fixes popup rendering so borders are always visible. Removes vi-only keys, unifies exit behavior, and makes dialogs match the C UI.
New Features
Bug Fixes
Written for commit f1c3485. Summary will update on new commits.