Add conditions for pushing images from GithubCI to DockerHub #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
force-pushed
the
fix/push_image_only_on_push
branch
from
836c5c7 to
c23daef
Compare
This commit restricts the condition for GithubCI to push the docker image to DockerHub, so the pull requests will perform the GithubCI build runs but it won't pollute the DockerHub images by pushing the built images up there.
henrybear327
force-pushed
the
fix/push_image_only_on_push
branch
from
c23daef to
7cc8aae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR restricts the condition for GithubCI to push the docker image to DockerHub, so the pull requests will perform the GithubCI build runs but it won't pollute the DockerHub images by pushing the built images up there.