Conversation
This splits monolithic Makefile into mk/ fragments (toolchain, features, deps, tests, format) and add Kconfiglib-based configuration via 'make config' (interactive menuconfig) or 'make defconfig'. Features (SLIRP networking, web observatory) are enabled by default and toggled via CONFIG_HAS_WEB in .config. The build mode (debug/release) is also configurable through Kconfig. Kconfiglib is fetched on demand from sysprog21/Kconfiglib via shallow clone into tools/kconfig/, cleaned by 'make distclean'. Change-Id: I719856353c77c9c69872b9180fa6d6296b732a6c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits monolithic Makefile into mk/ fragments (toolchain, features, deps, tests, format) and add Kconfiglib-based configuration via 'make config' (interactive menuconfig) or 'make defconfig'.
Features (SLIRP networking, web observatory) are enabled by default and toggled via CONFIG_HAS_WEB in .config. The build mode (debug/release) is also configurable through Kconfig.
Kconfiglib is fetched on demand from sysprog21/Kconfiglib via shallow clone into tools/kconfig/, cleaned by 'make distclean'.
Change-Id: I719856353c77c9c69872b9180fa6d6296b732a6c
Summary by cubic
Modularized the build into
mk/fragments and integratedKconfiglibso features and build mode are configured viamake config/make defconfig. Builds now require a.config; runmake defconfig && makeor use the interactivemake config.New Features
make config(menuconfig),make defconfig,make oldconfig, andmake savedefconfiggenerate and manage.config(defaults:CONFIG_HAS_SLIRP=y,CONFIG_HAS_WEB=y, debug build).CONFIG_HAS_SLIRP,CONFIG_HAS_WEB; build mode:CONFIG_BUILD_DEBUGorCONFIG_BUILD_RELEASE; optionalCONFIG_LKL_DIR.Kconfiglibdownload, pinned intotools/kconfig/; removed bymake distclean. LKL andminislirpstill auto-fetched when enabled..configchanges trigger object rebuilds.Migration
make defconfigonce, thenmake. Use two steps (e.g.,make defconfig && make), notmake defconfig all.make defconfigbefore building/tests.make oldconfigwhen new options are added;make distcleanresets.configand removestools/kconfig/.Written for commit cf507ae. Summary will update on new commits.