Support file bind mounts in addition to directories#49
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kbox_apply_bind_mounts() unconditionally mkdir'd target before MS_BIND, silently failing for file sources. Stat the host source to determine its type: create a directory target via mkdir for directories, or an empty file target via openat(O_CREAT|O_EXCL) for regular files. Reject symlinks, devices, and other non-regular types up front. On EEXIST, verify the existing target matches the expected type to catch mismatches early instead of deferring to a confusing mount error. Close #39 Change-Id: I287c480fbe80301911e0b64702db2b6abb48a70f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kbox_apply_bind_mounts() unconditionally mkdir'd target before MS_BIND, silently failing for file sources. Stat the host source to determine its type: create a directory target via mkdir for directories, or an empty file target via openat(O_CREAT|O_EXCL) for regular files. Reject symlinks, devices, and other non-regular types up front.
On EEXIST, verify the existing target matches the expected type to catch mismatches early instead of deferring to a confusing mount error.
Close #39
Change-Id: I287c480fbe80301911e0b64702db2b6abb48a70f
Summary by cubic
Enable bind-mounting regular files alongside directories. Also improves validation and error messages to fail fast on mismatches.
New Features
mkdir, file viaopenat(O_CREAT|O_EXCL)); rejects symlinks and other non-regular sources.Bug Fixes
mkdir; onEEXIST, verifies target type and improves errors; validates inputs (s,specs,count).Written for commit 0000f97. Summary will update on new commits.