Fix uninitialized variable in error path #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error occurs, the goto error handling path attempts to free and return variables that might not have been initialized yet. This may lead to undefined behavior or crashes. This patch ensures variables are initialized properly before use in the error path, and avoids double-free or invalid free issues. Observed with valgrind: ==33961== Conditional jump or move depends on uninitialised value(s) ==33961== at 0x4849845: free (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==33961== by 0x1093A7: main (in /home/weiso131/linux_2025/ksort/user)
Contributor
|
Thank @weiso131 for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs, the goto error handling path attempts to free and return variables that might not have been initialized yet. This may lead to undefined behavior or crashes.
This patch ensures variables are initialized properly before use in the error path, and avoids double-free or invalid free issues.
Observed with valgrind:
==33961== Conditional jump or move depends on uninitialised value(s)
==33961== at 0x4849845: free
(in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==33961== by 0x1093A7: main
(in /home/weiso131/linux_2025/ksort/user)