Implement poll to make select work correctly #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ftrace, I observed that during the select system call, the kernel invokes do_select → select_poll_one → vfs_poll → file->f_op->poll. However, the kxo device did not implement the poll file operation.
In this case, vfs_poll returns a default mask that causes select to assume the file is always ready for I/O, even if a subsequent read would block.
This behavior led to user-facing issues in xo-user. For example, attempting to pause (Ctrl+P) or
stop (Ctrl+Q) could be delayed or ignored due to
the blocking nature of kxo's read when no data is available.
I implemented poll support using a wait queue to resolve this problem.
References: