Conversation
The symbols DEMO_WIN_X, DEMO_WIN_Y, and the forward declaration for get_demo_window_height were previously placed inside the '#ifdef CONFIG_DEMO_CALCULATOR' block in tests/example.c. When the calculator demo is disabled in Kconfig, these crucial symbols are excluded, causing compilation to fail for all other demos (like clock, vector, nyan cat) that rely on them for window positioning and sizing. Close #19
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbols DEMO_WIN_X, DEMO_WIN_Y, and the forward declaration for get_demo_window_height were previously placed inside the '#ifdef CONFIG_DEMO_CALCULATOR' block in tests/example.c.
When the calculator demo is disabled in Kconfig, these crucial symbols are excluded, causing compilation to fail for all other demos (like clock, vector, nyan cat) that rely on them for window positioning and sizing.
Close #19
Summary by cubic
Fix compilation of non-calculator demos when the calculator is disabled by moving shared window constants and a forward declaration out of the calculator-only block.
Written for commit 020147c. Summary will update on new commits.