Skip to content

Replace $(shell) with portable $(python) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jserv merged 1 commit into from
Mar 1, 2026
Merged

Replace $(shell) with portable $(python) #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions configs/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,32 @@ mainmenu "libiui Configuration"
menu "Toolchain Configuration"

# Compiler detection using scripts/detect-compiler.py
config COMPILER_TYPE
string
default "$(shell,scripts/detect-compiler.py 2>/dev/null || echo Unknown)"

# Uses $(python,...) for portable boolean checks (no shell dependency).
# run() executes argv without a shell; assert converts True/False to y/n.
# sys.executable ensures the script runs under the same Python as Kconfiglib.
config CC_IS_EMCC
def_bool $(shell,scripts/detect-compiler.py --is Emscripten 2>/dev/null)
def_bool $(python,assert run(sys.executable, 'scripts/detect-compiler.py', '--is', 'Emscripten'))

config CC_IS_CLANG
def_bool $(shell,scripts/detect-compiler.py --is Clang 2>/dev/null)
def_bool $(python,assert run(sys.executable, 'scripts/detect-compiler.py', '--is', 'Clang'))

config CC_IS_GCC
def_bool $(shell,scripts/detect-compiler.py --is GCC 2>/dev/null)
def_bool $(python,assert run(sys.executable, 'scripts/detect-compiler.py', '--is', 'GCC'))

# Derive compiler type string from the boolean checks above.
# $(python,...) only returns y/n, so string-valued configs use conditionals.
# Precedence: Emscripten > Clang > GCC (emcc is Clang-based, so check it first).
config COMPILER_TYPE
string
default "Emscripten" if CC_IS_EMCC
default "Clang" if CC_IS_CLANG
default "GCC" if CC_IS_GCC
default "Unknown"

# Check if emcc is available in PATH (for defconfig generation)
# Check if emcc is available in PATH (for defconfig generation).
# In-process via shutil.which() -- no subprocess needed.
config HAVE_EMCC
def_bool $(shell,scripts/detect-compiler.py --have-emcc 2>/dev/null)
def_bool $(python,assert shutil.which('emcc'))

comment "Build mode: WebAssembly (Emscripten)"
depends on CC_IS_EMCC
Expand All @@ -43,7 +53,7 @@ endmenu
config HAVE_SDL2
bool
default n if CC_IS_EMCC
default $(shell,pkg-config --exists sdl2 2>/dev/null && echo y || echo n) if !CC_IS_EMCC
default $(python,assert shutil.which('pkg-config') and run('pkg-config', '--exists', 'sdl2')) if !CC_IS_EMCC

# Backend Selection (mutual exclusion)

Expand Down
Loading