Add error handling for class_create()#362
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
Can you confirm the similar issues have been resolved within whole example code? |
Check the return value of class_create(), unregistering the char device and returning the error code if class creation fails. Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
Collaborator
Author
Done. |
Contributor
|
Thank @EricccTaiwan for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the return value of class_create() in chardev.c and chardev2.c, unregistering the char device and returning the error code if class creation fails.
Summary by cubic
Handle class_create() failures in the example char drivers to avoid leaks and return clear errors. On failure, we now unregister the char device and return PTR_ERR.
Written for commit fdf50cc. Summary will update on new commits.