Conversation
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="examples/vnetloop.c">
<violation number="1" location="examples/vnetloop.c:27">
P2: `u64` packet/byte counters are updated and read without synchronization, which can yield inconsistent stats under concurrent access (especially on 32-bit builds).</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This introduces new kernel module examples (dma.c, blkram.c, vnetloop.c) and corresponding book sections covering memory/time/data-movement, PCI, USB, block, and network driver subsystems. It also adds poll/select/epoll, async notification, MMIO, DMA/mmap, scatter-gather, and modern-interface-choices sections to the book text, and updates the version baseline statement to reflect 5.10 minimum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces new kernel module examples (dma.c, blkram.c, vnetloop.c) and corresponding book sections covering memory/time/data-movement, PCI, USB, block, and network driver subsystems.
It also adds poll/select/epoll, async notification, MMIO, DMA/mmap, scatter-gather, and modern-interface-choices sections to the book text, and updates the version baseline statement to reflect 5.10 minimum.
Summary by cubic
Adds three kernel module examples (DMA demo, RAM-backed blk‑mq block device, and virtual loopback Ethernet) and expands the book with modern DMA/MMIO, poll/epoll, and PCI/USB/block/network chapters. Sets Linux v5.10 as the minimum baseline and embeds the new samples in the text.
examples/dma.c(sets DMA mask, coherent + streaming DMA via syntheticplatform_device, version-aware.removefor 5.10–6.11),examples/blkram.c(RAM disk using blk‑mq with guards for 5.10–6.9+, kmap and queue helper transitions),examples/vnetloop.c(virtualnet_devicelooping TX→RX with 64‑bit stats). Updatedexamples/Makefileto builddma.o,blkram.o,vnetloop.o.lkmpg.tex): Added poll/select/epoll and fasync; a Memory/Time/Data Movement chapter (timekeeping, allocation, user–kernel copies); MMIO; DMA + mmap with scatter‑gather and debugging; modern interface choices; and subsystem chapters for PCI, USB, block, and network with sample embeds. Baseline set to Linux v5.10.Written for commit 563b6db. Summary will update on new commits.