Handle class inheritance correctly #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If fields or methods are not found in the class, pitifulvm will try to find them from the parent class recursively. Note that ptitfulvm have not supported objects' fields in the parent class yet, so `getfield` and `putfield` still don't find fields from the parent class. Add a new test script: "Inherit.java"
jserv
reviewed
Aug 7, 2022
In `new` opcode, jvm needs to call constructor and initialization in order. The sequence is begin at base class static initialization, and then derived class static initialization. After all classes are initialized, base class constructor will be executed, then execute its child class constructor. Add a new test script: Initializer.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch handle fields and methods existing in the parent class. If fields or methods are not found in the class, pitifulvm will try to find them from the parent class recursively. Also, ensure all constructors and static initialization are executed in order.