Add line and column numbers to error diagnostics #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jserv
requested changes
Nov 24, 2025
Collaborator
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Check 'CONTRIBUTING.md' carefully and indent source files with 'clang-format-18'.
johndoesstuff
force-pushed
the
fix/error-at-with-line-and-column
branch
from
fcfa9fc to
34f235d
Compare
jserv
reviewed
Nov 24, 2025
The original error() function only showed the raw byte offset and a caret line, this change adds 1-based line and column numbers while leaving everything else unchanged. This is done by reusing start_idx and backtracking through SOURCE to count newlines.
johndoesstuff
force-pushed
the
fix/error-at-with-line-and-column
branch
from
34f235d to
c33b078
Compare
Collaborator
|
Thank @johndoesstuff for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error() function previously only showed a raw byte offset.
This PR adds proper 1-based line:column information while preserving the original diagnostic layout and caret position exactly.
No behaviour changes other than the added location output.
All tests pass, zero regressions.
Fixes the TODO in error().
Summary by cubic
Add 1-based line:column numbers to error diagnostics instead of a raw byte offset, preserving the caret line and diagnostic layout.
Written for commit c33b078. Summary will update automatically on new commits.