Skip to content

Conversation

@RoyWFHuang
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to include section headers like "Description" in your git commit messages. Always opt for clear and descriptive language that explains your reasoning and the methods you employed to fix a specific problem.

@jserv jserv changed the title Fix rm hard link problem and remove kernel module make cache leak Fix rm hard link problem and resolve cache leak Feb 21, 2024
@RoyWFHuang
Copy link
Collaborator Author

There's no need to include section headers like "Description" in your git commit messages. Always opt for clear and descriptive language that explains your reasoning and the methods you employed to fix a specific problem.

Complete, leaving only bug description and solution

@RoyWFHuang RoyWFHuang requested a review from jserv February 21, 2024 12:49
@jserv
Copy link
Collaborator

jserv commented Feb 21, 2024

Complete, leaving only bug description and solution

Refine the git commit messages by validating their English grammar.

@RoyWFHuang
Copy link
Collaborator Author

Complete, leaving only bug description and solution

Refine the git commit messages by validating their English grammar.

Refine the commit messages, please review them, thanks.

Copy link
Collaborator

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read https://cbea.ms/git-commit/ carefully and enforce the rules.

Add the inode name compration in the unlink function

Since the hard link uses the same inode number as the original file
inode, it's necessary to check the name to prevent deletion of the
wrong inode.
Add the 'ihold()' into 'simplefs_link' function

The hard link cache and old file cache are both in the cache list,
the "kill_block_super" attempts to free the inode cache, it will
decrement "i_count" twice. Therefore, if 'i_count' is not 0,
'destroy_inode' will not be called.
@RoyWFHuang RoyWFHuang requested a review from jserv February 22, 2024 04:52
@jserv jserv merged commit d0fa94b into sysprog21:master Feb 22, 2024
@jserv
Copy link
Collaborator

jserv commented Feb 22, 2024

Thank @RoyWFHuang for contributing!

@RoyWFHuang RoyWFHuang deleted the bug_fix branch March 29, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants