-
Notifications
You must be signed in to change notification settings - Fork 104
Fix rm hard link problem and resolve cache leak #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jserv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to include section headers like "Description" in your git commit messages. Always opt for clear and descriptive language that explains your reasoning and the methods you employed to fix a specific problem.
Complete, leaving only bug description and solution |
Refine the git commit messages by validating their English grammar. |
Refine the commit messages, please review them, thanks. |
jserv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read https://cbea.ms/git-commit/ carefully and enforce the rules.
Add the inode name compration in the unlink function Since the hard link uses the same inode number as the original file inode, it's necessary to check the name to prevent deletion of the wrong inode.
Add the 'ihold()' into 'simplefs_link' function The hard link cache and old file cache are both in the cache list, the "kill_block_super" attempts to free the inode cache, it will decrement "i_count" twice. Therefore, if 'i_count' is not 0, 'destroy_inode' will not be called.
|
Thank @RoyWFHuang for contributing! |
No description provided.