Skip to content

Fix rm hard link problem and resolve cache leak #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Fix rm hard link problem and resolve cache leak #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f18a398
Fix rm hard link problem
RoyWFHuang Feb 19, 2024
6958909
Resolve cache leak from hard link
RoyWFHuang Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion inode.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,8 @@ static int simplefs_remove_from_dir(struct inode *dir, struct dentry *dentry)
}
/* Remove file from parent directory */
for (fi = 0; fi < SIMPLEFS_FILES_PER_BLOCK; fi++) {
if (dblock->files[fi].inode == inode->i_ino) {
if (dblock->files[fi].inode == inode->i_ino &&
!strcmp(dblock->files[fi].filename, dentry->d_name.name) ) {
found = true;
if (fi != SIMPLEFS_FILES_PER_BLOCK - 1) {
memmove(dblock->files + fi, dblock->files + fi + 1,
Expand Down Expand Up @@ -896,6 +897,7 @@ static int simplefs_link(struct dentry *old_dentry,
brelse(bh);

inode_inc_link_count(inode);
ihold(inode);
d_instantiate(dentry, inode);
return ret;

Expand Down