Skip to content

Conversation

@crawfxrd
Copy link
Member

  • Use distro-provided rustup package on Fedora, Arch
  • Use sh compatible commands where possible
  • Update command for installing pinned Rust toolchain
  • Remove progress messages
  • Remove commands that conflict with running the script in other contexts
    • git-hooks breaks calling from firmware-open directory
    • submodule checkout is only required for external flashing and for generating initial board configs from firmware-open

- Use distro-provided rustup package on Fedora, Arch
- Use sh compatible commands where possible
- Update command for installing pinned Rust toolchain
- Remove progress messages
- Remove commands that conflict with running the script in other contexts
  - git-hooks breaks calling from firmware-open directory
  - submodule checkout is only required for external flashing and for
    generating initial board configs from firmware-open

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd requested review from a team March 11, 2025 15:56
@jacobgkau jacobgkau self-assigned this Mar 12, 2025
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works on Pop!_OS 22.04 & 24.04. New Arch & Fedora package names are correct. Now works when run from firmware-open directory where it didn't before.

@crawfxrd crawfxrd merged commit 05744ac into master Mar 12, 2025
48 checks passed
@crawfxrd crawfxrd deleted the deps-script branch March 12, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants