daemon: add basic support for sd_is_socket_sockaddr#31
Merged
keszybz merged 7 commits intosystemd:masterfrom Mar 11, 2017
Merged
daemon: add basic support for sd_is_socket_sockaddr#31keszybz merged 7 commits intosystemd:masterfrom
keszybz merged 7 commits intosystemd:masterfrom
Conversation
keszybz
force-pushed
the
is_socket_sockaddr
branch
from
a960292 to
cef69e9
Compare
keszybz
force-pushed
the
is_socket_sockaddr
branch
2 times, most recently
from
ee3d441 to
584cedc
Compare
When running in a chroot, doctests that called journal.stream would fail with ENOENT. Move the tests to test_journal, where we can skip tests properly (without uglyfying the documentation). Fixes systemd#32.
In _reader we were raising OSError(errno=ENOSYS), but in _dameon we were raising NotImplementedError. Let's always use ENOSYS. Also, make the messages in _reader more specific. Fixes systemd#33.
Later on a proper wrapper in daemon.py should be added.
Oh, Ubuntu!
Not particularly useful, but let's have it for completeness.
Specifying the address without does not work.
keszybz
force-pushed
the
is_socket_sockaddr
branch
from
584cedc to
bc691d8
Compare
Member
Author
|
At least the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Later on a proper wrapper in daemon.py should be added.
This should wait until the support in systemd is merged.