replace dict.iteritems() with dict.items() to support py3#39
Merged
keszybz merged 1 commit intosystemd:masterfrom Mar 11, 2017
Merged
replace dict.iteritems() with dict.items() to support py3#39keszybz merged 1 commit intosystemd:masterfrom
keszybz merged 1 commit intosystemd:masterfrom
Conversation
py3 doesn't have dict.iteritems() anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py3 doesn't have
dict.iteritems()anymore so it fails under py3 env. So replacedict.iteritems()withdict.items().six.iteritems()can be used but it requiressixas a dependency library.Previous test cases doesn't reveals the failure under py3 env so introduce a MockSender and inject sender function to increase testability.