work correctly without CONFIG_SCHED_DEBUG#10
Merged
sofar merged 1 commit intosystemd:masterfrom Aug 30, 2016
Merged
Conversation
The app appeared to work without CONFIG_SCHED_DEBUG (no error messages), but the PS part of the graph was not plotted, and process command lines were not collected with -C. It was hard to find out what's the reason. A small change fixes the code to work correctly without requirement for this config.
Contributor
|
Looks OK from what I can see quickly... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, systemd-bootchart appears to work without CONFIG_SCHED_DEBUG (no error messages),
but the PS part of the graph is not plotted, and process command lines
are not collected with -C. It is hard to discover what's the reason. A
small change fixes the code to work correctly without requirement for
this kernel config.
Note: I can amend this commit to try moving the
/sched-related part to a separate function, but for now submitting as is, for easier analysis and verification of what it does.