Fix RFC 3339 vs RFC 3164 mixup for message format#145
Merged
ssahani merged 6 commits intosystemd:mainfrom Mar 25, 2026
Merged
Conversation
The message format was incorrectly referred to as RFC 3339 (a date/time format) throughout the codebase, when it should be RFC 3164 (the BSD syslog protocol). The timestamp formatting function format_rfc3339_timestamp() is left unchanged as it correctly formats timestamps per RFC 3339. Fixes: systemd#144
ssahani
force-pushed
the
fix/rfc3164-rename
branch
from
32adc70 to
fe49dd9
Compare
- Rewrite README: remove excessive decoration, fix build instructions to use meson properly, consolidate config docs - Fix SECURITY.md: wrong config option CertificateAuthentication should be TLSCertificateAuthMode - Add GitHub issue templates (bug report, feature request) - Add pull request template
- Add debian/ packaging: control, rules, changelog, copyright, postinst - Add Arch Linux PKGBUILD - Update RPM spec: fix meson version (>= 0.51), include CHANGELOG.md and SECURITY.md in docs - Update CI: proper dpkg-buildpackage for DEB, add Arch Linux build job, update Fedora matrix to latest/41, remove Rocky 8 - Clean up man page: remove duplicated troubleshooting/performance tuning content that belongs in README, keep it as a proper reference
- DEB builds: remove debian/compat (conflicts with debhelper-compat in debian/control) - RPM builds (Fedora): use tar instead of git archive (container checkout lacks .git), add fetch-depth: 0 and safe.directory - RPM builds (Rocky Linux 9): separate job with CRB repo enabled, install meson/ninja via pip3 (not in EPEL/CRB) - Remove startsWith conditionals for Rocky vs Fedora deps — use separate jobs instead for clarity
- RPM jobs: remove git config step that ran before git was installed, remove fetch-depth (not needed since using tar instead of git archive) - DEB jobs: call meson directly in debian/rules instead of using dh_auto_configure which injects conflicting --prefix=/usr
- RPM: add missing python3-devel and python3-lxml build deps - RPM: fix Source0 URL to match tarball name created in CI - DEB: remove debian/install (conflicts with manual meson install in override_dh_auto_install)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The message format was incorrectly referred to as RFC 3339 (a date/time format) throughout the codebase, when it should be RFC 3164 (the BSD syslog protocol). The timestamp formatting function format_rfc3339_timestamp() is left unchanged as it correctly formats timestamps per RFC 3339.
Fixes: #144