User session forcefully ended after logind restart

[jpalus]

systemd 245.6

Used distribution
PLD Linux

Expected behaviour you didn't see
User sessions continue to work after logind restart.

Unexpected behaviour you saw
User session is forcefully finished approximately after 5min since logind restart.

Steps to reproduce the problem
Restart systemd-logind.

As far as I understand code logind saves its state in /run/systemd/users where each file has name equal to user UID. However instead of calling manager_add_user_by_uid it calls manager_add_user_by_name. In the latter case VALID_USER_ALLOW_NUMERIC is not passed to valid_user_group_name, only VALID_USER_RELAX.

static int manager_enumerate_users(Manager *m) {
...
        /* Read in user data stored on disk */
        d = opendir("/run/systemd/users");
        if (!d) {
                if (errno == ENOENT)
                        return 0;

                return log_error_errno(errno, "Failed to open /run/systemd/users: %m");
        }

        FOREACH_DIRENT(de, d, return -errno) {
                User *u;

                if (!dirent_is_file(de))
                        continue;

                k = manager_add_user_by_name(m, de->d_name, &u);
                if (k < 0) {
                        r = log_warning_errno(k, "Failed to add user by file name %s, ignoring: %m", de->d_name);

Logs:

cze 11 14:15:11 pine systemd[1]: Starting Login Service...
cze 11 14:15:11 pine systemd-logind[1672]: New seat seat0.
cze 11 14:15:11 pine systemd-logind[1672]: Failed to add user by file name 1000, ignoring: Invalid argument
cze 11 14:15:11 pine systemd-logind[1672]: User enumeration failed: Invalid argument
cze 11 14:15:11 pine systemd-logind[1672]: User of session c2 not known.
cze 11 14:15:11 pine systemd-logind[1672]: Session enumeration failed: No such file or directory
....
cze 11 14:20:18 pine systemd[1]: Stopping User Manager for UID 1000...

[eoli3n]

I think that i'm facing that bug on 245.4-4ubuntu3.2.
It occurs after systemd-logind to crash

nov. 03 15:31:32 prodpeda-x2go-focal1 systemd[1]: ^[[0;1;39msystemd-logind.service: Unexpected error response from GetNameOwner(): Connection terminated
nov. 03 15:31:32 prodpeda-x2go-focal1 systemd[1]: systemd-logind.service: Succeeded.
nov. 03 15:31:32 prodpeda-x2go-focal1 systemd[1]: ^[[0;1;39m^[[0;1;39msystemd-logind.service: Consumed 4.012s CPU time.
nov. 03 15:31:32 prodpeda-x2go-focal1 systemd[1]: systemd-logind.service: Scheduled restart job, restart counter is at 1.
nov. 03 15:31:32 prodpeda-x2go-focal1 systemd[1]: Stopped Login Service.
nov. 03 15:31:32 prodpeda-x2go-focal1 systemd[1]: ^[[0;1;39m^[[0;1;39msystemd-logind.service: Consumed 4.012s CPU time.
nov. 03 15:31:32 prodpeda-x2go-focal1 systemd[1]: Starting Login Service...
nov. 03 15:31:33 prodpeda-x2go-focal1 systemd-logind[1059711]: New seat seat0.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 0, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 20146560, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22002676, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22007270, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22001248, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22018198, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22015343, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21913913, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21607534, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22001706, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22001409, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22002035, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21902459, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21913851, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21509941, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21910192, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21915857, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21602533, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21512149, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21903285, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21805953, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21915423, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21508357, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21909615, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21703430, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21804381, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21913254, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 85277, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22006023, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21911600, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22015477, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22012155, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21811161, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22014483, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22019884, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21803046, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21910900, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21911580, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21601155, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21903327, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22011855, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21815107, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22015711, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21908669, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21602127, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21910830, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21815251, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22013136, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21612513, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22006958, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22002861, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21904218, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21909062, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21904710, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22011969, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22010705, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21904973, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21905151, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21916737, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21905121, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21910264, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 21909247, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mFailed to add user by file name 22015999, ignoring: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mUser enumeration failed: Invalid argument
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 1117 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 1111 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 515 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 538 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 563 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 560 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 557 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 532 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 526 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 513 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 511 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 501 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 492 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 508 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 497 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 486 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 479 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 477 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 475 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 473 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 469 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 456 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 447 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session 278 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;39mUser of session c1 not known.
nov. 03 15:31:34 prodpeda-x2go-focal1 systemd-logind[1059711]: ^[[0;1;38;5;185m^[[0;1;39m^[[0;1;38;5;185mSession enumeration failed: No such file or directory

Any workaround before 245.6 to be available on Ubuntu ?