Skip to content

Conversation

@jsynacek
Copy link
Contributor

@jsynacek jsynacek commented Oct 9, 2015

No description provided.

@keszybz
Copy link
Member

keszybz commented Oct 9, 2015

I didn't check it it works..., but those new Make rules look a bit iffy:

  • silent compilation should be done properly with AM_V_*, see e.g. AM_V_M4 for an example
  • patsubst is overkill, $(_po_files:.po=.mo) should be enough

@filbranden
Copy link
Member

I'll try to review this commit tomorrow... Thanks!

@mbiebl
Copy link
Contributor

mbiebl commented Oct 10, 2015

With intltool we had a po/Makefile, where you could run "make -C po update-po", which created a systemd.pot and updated the existing .po files. Shouldn't we add similar functionality when using itstool?

@zonque
Copy link
Member

zonque commented Oct 10, 2015

itstool is now in the list of packages Semaphore will install, so the build shouldn't fail due to that anymore.

@jsynacek
Copy link
Contributor Author

With intltool we had a po/Makefile, where you could run "make -C po update-po", which created a >systemd.pot and updated the existing .po files. Shouldn't we add similar functionality when using >itstool?

Yep. I totally forgot about that part. Also, without that Makefile, translations are not installed on make install.

@jsynacek
Copy link
Contributor Author

I ran into a pretty big issue...

The proper way to create the po/Makefile{,.in,.in.in} files is to run gettextize in a similar fashion as the intltoolize script was run. However, for some reason, gettextize is interactive and requires the caller to press Return everytime it's run. And it reads /dev/tty directly, so it can't be used from non-interactive tools. This basically means that we would have to bundle at least Makefile.in.in and probably some m4 scripts.

Any ideas?

@poettering
Copy link
Member

@jsynacek a bit of googling reveals this:

https://lists.gnu.org/archive/html/bug-gettext/2011-12/msg00001.html

maybe "autopoint" is the tool to use here?

@jsynacek
Copy link
Contributor Author

v2: #1576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

6 participants