Skip to content

hostname: fix fallback chassis type#24385

Merged
bluca merged 2 commits intosystemd:mainfrom
yuwata:hostname-chassis
Aug 22, 2022
Merged

hostname: fix fallback chassis type#24385
bluca merged 2 commits intosystemd:mainfrom
yuwata:hostname-chassis

Conversation

@yuwata
Copy link
Copy Markdown
Member

@yuwata yuwata commented Aug 22, 2022

Fixes a bug introduced by 8c8b180 (v251).

Fixes #24384.

@poettering
Copy link
Copy Markdown
Member

lgtm, but shellcheck/lint/code-scanning doesn't like it.

@bluca bluca added the ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR label Aug 22, 2022
@yuwata yuwata removed the ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR label Aug 22, 2022
@yuwata
Copy link
Copy Markdown
Member Author

yuwata commented Aug 22, 2022

The CI failure should be fixed now. PTAL.

The first commit needs to be backported to v251-stable.

@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review labels Aug 22, 2022
@bluca bluca merged commit d4001c5 into systemd:main Aug 22, 2022
@yuwata yuwata deleted the hostname-chassis branch August 22, 2022 14:56
@keszybz keszybz removed good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed needs-stable-backport labels Sep 30, 2022
liuyangxy pushed a commit to fedora-riscv/systemd that referenced this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

hostname: Chassis type through org.freedesktop.hostname1 but returned an emtpy string.

5 participants