Skip to content

udev: fix by-id symlinks#25246

Merged
bluca merged 3 commits intosystemd:mainfrom
yuwata:udev-serial-by-id-symlinks
Nov 4, 2022
Merged

udev: fix by-id symlinks#25246
bluca merged 3 commits intosystemd:mainfrom
yuwata:udev-serial-by-id-symlinks

Conversation

@yuwata
Copy link
Copy Markdown
Member

@yuwata yuwata commented Nov 3, 2022

Fixes a bug introduced by 479da11.

Fixes #25238.

yuwata added 3 commits November 3, 2022 09:53
@yuwata
udev: first set properties based on usb subsystem
01e704e 
After 479da11, the usb_id builtin
command does not set ID_SERIAL if ID_BUS is already set.
Before the commit, all properties set based on pci bus were overwritten
by the usb_id, hence now it is sufficient setting them only when ID_BUS is
not set yet.

Fixes systemd#25238.
@yuwata
udev: drop redundant call of usb_id and assignment of ID_USB_INTERFAC…
b2e53f5 
…E_NUM

The usb_id builtin command is already called in the above, and the
command sets the ID_USB_INTERFACE_NUM property.
@yuwata
udev: add safe guard for setting by-id symlink
5286da0 
The ID_BUS property is necessary for creating by-id symlinks.
@yuwata
Copy link
Copy Markdown
Member Author

yuwata commented Nov 3, 2022

The first commit needs to be backported to v252-stable.

@yuwata yuwata mentioned this pull request Nov 3, 2022
Closed
@jwilk
Copy link
Copy Markdown
Contributor

jwilk commented Nov 3, 2022

6c83054...5286da0 fixes it for me.
Thanks.

bluca
bluca reviewed Nov 3, 2022
View reviewed changes
@bluca bluca merged commit 93a1427 into systemd:main Nov 4, 2022
@yuwata yuwata deleted the udev-serial-by-id-symlinks branch November 4, 2022 23:24
@keszybz
Copy link
Copy Markdown
Member

keszybz commented Nov 24, 2022

The first commit was already included in v252.1.

@obra obra mentioned this pull request Jun 28, 2023
Closed
@m3cinc
Copy link
Copy Markdown

m3cinc commented Sep 17, 2023

Apparently the fis is not sufficient as the scripts are still not working in Debian 6.1.21-v7l+ #1642 SMP Mon Apr 3 17:22:30 BST 2023 armv7l, the current distributed version:
ls: cannot access '/dev/serial/by-id/': No such file or directory
Hope you can resolve as this impairs klipper functionality today!

@yuwata
Copy link
Copy Markdown
Member Author

yuwata commented Sep 17, 2023

@m3cinc Please open a new issue page with udevadm info DEVICE_PATH, udevadm test DEVICE_PATH, and the full contents of 60-serial.rules.
Otherwise, comments on already merged PR will be easily forgotten.

@m3cinc m3cinc mentioned this pull request Sep 17, 2023
Closed
@m3cinc
Copy link
Copy Markdown

m3cinc commented Sep 17, 2023 via email

@ghost
Copy link
Copy Markdown

ghost commented Sep 30, 2023

Folks, this does not work, the dongle for zwave is disappearing with 60-serial.rules
what version will fix this?
this really suck

@yuwata
Copy link
Copy Markdown
Member Author

yuwata commented Oct 1, 2023

@catchthemonster
The commit is backported to v252 as systemd/systemd-stable@dafd733, which is included in v252.1.

Please also see #28509.

@yuwata
Copy link
Copy Markdown
Member Author

yuwata commented Oct 1, 2023

@catchthemonster
Anyway, as I said in the above #25246 (comment), please open a new issue with detailed info.

@paradox460 paradox460 mentioned this pull request Oct 14, 2023
Closed
@paradox460 paradox460 mentioned this pull request Oct 30, 2023
Closed
jackpot51 pushed a commit to pop-os/systemd that referenced this pull request May 7, 2024
@bluca
Backport patches to fix tmpfiles error and missing /dev/serial/by-id/…
b47da36 
…usb-*

systemd/systemd#25246
systemd/systemd#25251

Closes: #1023311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluca bluca bluca approved these changes

Assignees

No one assigned

Labels

udev

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

udev: missing /dev/serial/by-id/usb-*

5 participants

@yuwata @jwilk @keszybz @m3cinc @bluca