Skip to content

boot: Read files in small chunks on broken firmware#25948

Merged
bluca merged 1 commit intosystemd:mainfrom
medhefgo:boot-bad-buffer-size
May 22, 2023
Merged

boot: Read files in small chunks on broken firmware#25948
bluca merged 1 commit intosystemd:mainfrom
medhefgo:boot-bad-buffer-size

Conversation

@medhefgo
Copy link
Copy Markdown
Contributor

@medhefgo medhefgo commented Jan 5, 2023

Fixes: #25911

@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label Jan 5, 2023
poettering
poettering reviewed Jan 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@poettering poettering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, if this works.

just some nitpicks

@poettering
Copy link
Copy Markdown
Member

poettering commented Jan 5, 2023

@kernle32dll please report back if this makes things work for you

@poettering poettering removed the please-review PR is ready for (re-)review by a maintainer label Jan 6, 2023
@medhefgo medhefgo marked this pull request as draft January 11, 2023 08:58
@kernle32dll kernle32dll mentioned this pull request Mar 25, 2023
Closed
@kernle32dll
Copy link
Copy Markdown

kernle32dll commented May 4, 2023

@poettering

As mentioned in #25911, this is now confirmed to work for me.

@medhefgo medhefgo marked this pull request as ready for review May 5, 2023 14:15
@ElvishJerricco ElvishJerricco mentioned this pull request May 22, 2023
Closed
@bluca bluca merged commit f70f992 into systemd:main May 22, 2023
@medhefgo medhefgo deleted the boot-bad-buffer-size branch May 22, 2023 10:12
@flokli
Copy link
Copy Markdown
Contributor

flokli commented May 22, 2023

Thanks! Can this also be backported to systemd-stable? NixOS/nixpkgs#227431 (comment) mentions this also systemd 253.

@medhefgo
Copy link
Copy Markdown
Contributor Author

medhefgo commented May 22, 2023

Yes, should be fine to backport.

This was referenced May 30, 2023
Merged
Merged
@aderumier
Copy link
Copy Markdown

aderumier commented Jun 28, 2023

Hi, could be great to have a backport to systemd-stable 252, for debian

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039508

@antongisli
Copy link
Copy Markdown

antongisli commented May 16, 2024

Backporting this would be amazing because on e.g. Ubuntu (24.04) there is no chance to get them updated to a later version. It would open up this technology for a much wider subsection of OS versions and help get adoption. We're using this with Kairos for Trusted Boot and with end users who need to use e.g. Ubuntu it is putting us in a tough spot.

@bluca
Copy link
Copy Markdown
Member

bluca commented May 16, 2024

This is already in Ubuntu 24.04

@antongisli
Copy link
Copy Markdown

antongisli commented May 16, 2024

thank you @bluca! I see that now, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poettering poettering poettering left review comments

@bluca bluca bluca approved these changes

Assignees

No one assigned

Labels

sd-boot/sd-stub/bootctl

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

systemd-boot: Error preparing initrd: Bad Buffer Size

10 participants

@medhefgo @poettering @kernle32dll @flokli @aderumier @antongisli @bluca @keszybz @mbiebl @yuwata