logind: Mark LidClosed property as "emits change"#30706
Merged
bluca merged 1 commit intosystemd:mainfrom Jan 10, 2024
Merged
Conversation
github-actions
bot
added
documentation
please-review
poettering
added
good-to-merge/waiting-for-ci 👍
Member
|
lgtm |
Member
|
Hmm, is this sufficient? Nothing is actually emitting those signals currently IIUC. |
Member
|
uh true. we do not generate those signals indeed. |
poettering
added
reviewed/needs-rework 🔨
garnacho
force-pushed
the
logind-power-emit
branch
from
3ad2e9c to
0d0b1bd
Compare
garnacho
changed the title
Contributor
Author
|
Eek, good catch, and silly me. I updated the patch adding notifications, and giving up OnExternalPower ATM. I notice that this does not handle yet changes in the number of outputs for |
github-actions
bot
added
please-review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bluca
added
ci-fails/needs-rework 🔥
It may be useful for DEs to follow changes on this property, esp. now that recent UPower has removed its own lid handling code. Related: https://gitlab.freedesktop.org/upower/upower/-/commit/07565ef6a1aa4a115f8ce51e259e408edbaed4cc
garnacho
force-pushed
the
logind-power-emit
branch
from
0d0b1bd to
5dc7b2c
Compare
Contributor
Author
|
Toned it down further to handling only LidClosed ATM. I'm having a hard time testing this patch over Silverblue, and at least on the GNOME side there's no immediate use for notifications on the Docked D-Bus property, I will save the hairier udev state tracking for future PRs. |
garnacho
changed the title
github-actions
bot
added
please-review
bluca
approved these changes
Jan 10, 2024
erikinkinen
pushed a commit
to droidian/upower
that referenced
this pull request
Feb 15, 2024
This reverts commit 07565ef. In the current systemd stable release 255 org.freedesktop.login1 does not emit a LidisClosed event, this has added in systemd `main` and will be availble in the next release. As GNOME control panel still uses UPower's `LidIsclosed` property and many other DE's such as Xfce/LXQt/Deepin as well revert this until the systemd changes are available in all Distributions. systemd/systemd#30706 Resolve: https://gitlab.freedesktop.org/upower/upower/-/issues/260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be useful for DEs to follow changes on these properties, esp. now that recent UPower has removed its own lid handling code.
Related: https://gitlab.freedesktop.org/upower/upower/-/commit/07565ef6a1aa4a115f8ce51e259e408edbaed4cc