sd-journal: trivial cleanups#31330
Merged
daandemeyer merged 4 commits intosystemd:mainfrom Feb 15, 2024
Merged
Conversation
…n_reliably() I understand that the original motivation to introduce the template argument here is to make journal_file_open() and _reliabrly() take the same arguments. But, yeah, that's completely unused, not necessary to complicate the code even the difference is not big.
Though, hopefully, the memory leak is hypothetical, as we always close journal file with the timer by journal_file_offline_close().
github-actions
bot
added
journal
util-lib
tests
journal-remote
please-review
daandemeyer
approved these changes
Feb 15, 2024
daandemeyer
added
good-to-merge/waiting-for-ci 👍
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split-out of #31311.