ukify: don't attempt to print emoji#35785
ukify: don't attempt to print emoji#35785dimich-dmb wants to merge 1 commit intosystemd:mainfrom dimich-dmb:main
Conversation
|
Why remove this? Sounds like a utf issue in your terminal? |
In my terminal I can see all UTF characters I need: Cyrillic, Greek, math, pseudographic, etc because I have installed corresponding fonts. To see emoji I need to find and install more fonts. I won't. Unprintable characters in system utility output are confusing: it's hard to understand whether it is an important warning failed to print or just someone's joke. |
|
Sorry, but we generally assume emojis just work if not on Linux VT and locale is in UTF-8 (see |
Sorry, but this assumption is wrong. Charmap "UTF-8" in locale doesn't mean that terminal is able to display any arbitrary unicode character.
I don't care how the issue will be fixed. I just proposed the simplest, and in my opinion, the most optimal solution. |
|
Ah, I looked into C code and got your point now. I couldn't even imagine it has special code to display emojis 🤦 Fortunately I've never seen them in output of other systemd utilites. Of course, in this case removing garbage from warning message doesn't fit into overall style of this software. The PR can be closed. |
Fixes #35784