sd-varlink/sd-json: add two new API calls #36137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YHNdnzj
approved these changes
Jan 23, 2025
yuwata
approved these changes
Jan 23, 2025
| <title>Return Value</title> | ||
|
|
||
| <para>On success, and if a field was removed <function>sd_json_variant_unset_field</function> returns a | ||
| positive non-zero integer. If no matching field was found it returns zero. On failure, it returns a |
Member
There was a problem hiding this comment.
Not a matter, but positive implies non-zero, sounds slightly redundant.
Member
Author
There was a problem hiding this comment.
i think that's not universally accepted... signbit(0) is true after all...
dunno, wanted to avoid any confusion.
poettering
force-pushed
the
varlink-two-calls
branch
from
78f6f90 to
25c2461
Compare
poettering
added
good-to-merge/waiting-for-ci 👍
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are kinda no-brainers, should have always existed.
Split out of #36133 which needs them.