Merged
Conversation
github-actions
bot
added
login
util-lib
apparmor
please-review
keszybz
requested changes
Nov 21, 2025
keszybz
added
good-to-merge/with-minor-suggestions
and removed
please-review
YHNdnzj
approved these changes
Nov 21, 2025
Follow-up for c3b3eea. Addresses systemd#39826 (comment).
- pam_log_oom() passes ENOMEM rather than -ENOMEM, hence previously pam_log_oom() did not return PAM_BUF_ERR. - We may (mistakenly) pass SYNTHETIC_ERRNO(). Let's gracefully handle that. - Introduce errno_to_pam_error() helper function.
Currently, the result of pam_debug_syslog_errno() is unused, hence this does not change anything and may be slightly redundant. But let's follow our usual coding style.
- Do not use '%m' when errno is not set. - Do not use pam_syslog_errno() when errno is not set. - Use pam_debug_syslog_errno() rather than log_debug_errno(). - Use 0 rather than PAM_SUCCESS in the function that returns negative errno, though PAM_SUCCESS == 0, hence that does not change any behavior. - Append missing full stop in the log message.
yuwata
force-pushed
the
various-fixlets-for-logging
branch
from
6b5554f to
924081f
Compare
Member
Author
yuwata
added
good-to-merge/waiting-for-ci 👍
github-actions
bot
removed
the
good-to-merge/waiting-for-ci 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.