kmod-setup: fix loading virtio modules, and load other vsock transport modules#40557
Open
yuwata wants to merge 2 commits intosystemd:mainfrom
Open
kmod-setup: fix loading virtio modules, and load other vsock transport modules#40557yuwata wants to merge 2 commits intosystemd:mainfrom
yuwata wants to merge 2 commits intosystemd:mainfrom
Conversation
github-actions
bot
added
the
please-review
YHNdnzj
reviewed
Feb 3, 2026
poettering
added
reviewed/needs-rework 🔨
yuwata
force-pushed
the
kmod-setup-vsock
branch
from
55b1514 to
8d75647
Compare
github-actions
bot
added
please-review
Member
Author
|
BTW, |
yuwata
force-pushed
the
kmod-setup-vsock
branch
from
8d75647 to
b4e4507
Compare
yuwata
force-pushed
the
kmod-setup-vsock
branch
from
b4e4507 to
2221dd6
Compare
yuwata
changed the title
poettering
reviewed
Feb 5, 2026
src/core/kmod-setup.c
Outdated
| } | ||
|
|
||
| static bool may_have_virtio(void) { | ||
| return detect_vm() > 0; |
Member
There was a problem hiding this comment.
that's such a generic check...
Member
There was a problem hiding this comment.
and does this even fix things? i mean, if the virtio bus doesn't show up early enough, then the kmods for it might not be able to attach to it either that early, so is this actually fixing the issue?
Member
Author
There was a problem hiding this comment.
Not sure, but force-pushed with a narrower check.
It seems the device with modalias e.g. virtio:d00000013v, only appears after the relevant module is loaded. So, we cannot use the string to determine if we should load the module. Fixes systemd#40503.
yuwata
force-pushed
the
kmod-setup-vsock
branch
from
2221dd6 to
2960e43
Compare
github-actions
bot
added
the
please-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40161.
Fixes #40503.