Skip to content

hwdb: Add workaround for backslash hardware issue in Purism Librem 13 V2#7826

Merged
poettering merged 1 commit intosystemd:masterfrom
ossobv:master
Jan 9, 2018
Merged

hwdb: Add workaround for backslash hardware issue in Purism Librem 13 V2#7826
poettering merged 1 commit intosystemd:masterfrom
ossobv:master

Conversation

@emansom
Copy link
Copy Markdown

@emansom emansom commented Jan 8, 2018

The Purism Librem 13 V2 laptop contains a physical backslash key which does not yield the correct keycode.

This pull request fixes the issue

@poettering poettering added the hwdb label Jan 9, 2018
@poettering poettering merged commit 05da675 into systemd:master Jan 9, 2018
@poettering
Copy link
Copy Markdown
Member

@emansom hmm, so this commit caused #7978. Are you sure the rule with "43" actually works? I figure this is supposed to say "backslash" instead?

@emansom
Copy link
Copy Markdown
Author

emansom commented Jan 24, 2018

43 actually works, backslash works as well

@emansom
Copy link
Copy Markdown
Author

emansom commented Jan 24, 2018

Opened a pull request #7984

@mbiebl
Copy link
Copy Markdown
Contributor

mbiebl commented Jan 24, 2018

If 43 works, is this a bug in python3-evdev?

@poettering
Copy link
Copy Markdown
Member

If 43 works, is this a bug in python3-evdev?

No. The tests insist that the symbolic name is used instead of the numeric value, and that's a good thing, and is what we always should do.

@mbiebl
Copy link
Copy Markdown
Contributor

mbiebl commented Jan 24, 2018

No. The tests insist that the symbolic name is used instead of the numeric value, and that's a good thing, and is what we always should do.

Ok, will add python3-evdev to Build-Depends then. This should then get synced to the Ubuntu based CI.

@poettering
Copy link
Copy Markdown
Member

Ok, will add python3-evdev to Build-Depends then. This should then get synced to the Ubuntu based CI.

Which unfortunately vanished... :-( I hope it'll be restored eventually

@bwrsandman
Copy link
Copy Markdown
Contributor

The MSI GS65 Stealth Thin has the same incorrect mapping.

@keszybz
Copy link
Copy Markdown
Member

keszybz commented Jun 18, 2018

@bwrsandman open a PR with the hwdb patch or it didn't happen ;)

@bwrsandman
Copy link
Copy Markdown
Contributor

@keszybz #9390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants