This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Use upstream buck2 from nixpkgs (ENG-1696)#2393
Merged
Merged
Conversation
Enabled by the following PR: NixOS/nixpkgs#243148 Signed-off-by: Nick Gerace <nick@systeminit.com>
ENG-1696 Use upstream buck2 from nixpkgs in our flake
Now available due to the following PR: NixOS/nixpkgs#243148 |
Contributor
Author
|
bors merge |
Contributor
Author
|
Merging as this is an "in place" dependency change for the most part. Yes, we are bumping our inputs, but they were changed relatively recently anyway. |
Contributor
|
Build succeeded: |
si-bors-ng Bot
added a commit
that referenced
this pull request
Jul 13, 2023
2394: Remove make-related deps (ENG-1697) r=nickgerace a=nickgerace Now, we are solely using buck2 and tilt. All Makefile-related content has been removed. This PR depends on #2393. <img src="https://media4.giphy.com/media/l0MYMV4Bf5zmV4TWE/giphy.gif"/> Co-authored-by: Nick Gerace <nick@systeminit.com>
![https://media4.giphy.com/media/l0MYMV4Bf5zmV4TWE/giphy.gif"/](https://media4.giphy.com/media/l0MYMV4Bf5zmV4TWE/giphy.gif"/){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled by the following PR:
NixOS/nixpkgs#243148