This repository was archived by the owner on Feb 6, 2026. It is now read-only.
feat(sdf-server, dal): Adding an edge for default schema variants at pkg import time#3424
Merged
si-bors-ng[bot] merged 3 commits intomainfrom Mar 22, 2024
Merged
Conversation
github-actions
Bot
added
A-sdf
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
3 times, most recently
from
2a7a446 to
553b46d
Compare
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
from
553b46d to
b5b608c
Compare
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
from
b5b608c to
2cfcc5b
Compare
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
3 times, most recently
from
aac57b2 to
c6006c9
Compare
stack72
changed the title
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
2 times, most recently
from
8c45331 to
3c7608f
Compare
Contributor
Author
|
bors try |
Contributor
tryBuild succeeded: |
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
2 times, most recently
from
38bc10a to
d5fe89b
Compare
Contributor
Author
|
bors try |
Contributor
tryBuild succeeded: |
Contributor
|
@stack72 pushed up a change: the |
…pkg import time Schema / Schema Variant Edges now exist as follows: DEFAULT: Schema -> Uses -> Schema Variant In order to make a schema variant the default for a schema, we need to update the correct edge from Use to Default: UPDATE: Schema -> Default -> Schema Variant Therefore, when we are setting a default schema variant we need to find any existing Default edges and convert them back to uses AND we need to find the existing Use edge between our nodes and change that to be a Default
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
2 times, most recently
from
2c9cdf3 to
2b6b2b6
Compare
Contributor
Author
|
bors merge |
si-bors-ng Bot
added a commit
that referenced
this pull request
Mar 22, 2024
3424: feat(sdf-server, dal): Adding an edge for default schema variants at pkg import time r=stack72 a=stack72 Schema / Schema Variant Edges now exist as follows: DEFAULT: Schema -> Uses -> Schema Variant In order to make a schema variant the default for a schema, we need to update the correct edge from Use to Default: UPDATE: Schema -> Default -> Schema Variant Therefore, when we are setting a default schema variant we need to find any existing Default edges and convert them back to uses AND we need to find the existing Use edge between our nodes and change that to be a Default Co-authored-by: stack72 <public@paulstack.co.uk> Co-authored-by: Zachary Hamm <zack@systeminit.com>
Contributor
|
Build failed: |
…the edge info in the merkle tree hash calculation
stack72
force-pushed
the
WIP-Adding-default-schema-variants
branch
from
2b6b2b6 to
07fb3a7
Compare
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema / Schema Variant Edges now exist as follows:
DEFAULT: Schema -> Uses -> Schema Variant
In order to make a schema variant the default for a schema, we need to update the
correct edge from Use to Default:
UPDATE: Schema -> Default -> Schema Variant
Therefore, when we are setting a default schema variant we need to find any existing
Default edges and convert them back to uses AND we need to find the existing Use edge
between our nodes and change that to be a Default