This repository was archived by the owner on Feb 6, 2026. It is now read-only.
feat(*): move workspace snapshots into layerdb#3458
Merged
si-bors-ng[bot] merged 1 commit intomainfrom Mar 19, 2024
Merged
Conversation
github-actions
Bot
added
A-si-settings
Contributor
Author
|
bors try |
Contributor
tryMerge conflict. |
zacharyhamm
force-pushed
the
move-snapshot-into-layer-cache
branch
from
ed8765b to
5832479
Compare
Contributor
Author
|
bors try |
Contributor
tryBuild failed: |
Co-Authored-By: Scott Prutton <scott@systeminit.com>
zacharyhamm
force-pushed
the
move-snapshot-into-layer-cache
branch
from
5832479 to
d7a9e96
Compare
Contributor
Author
|
bors try |
Contributor
tryBuild succeeded: |
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves storage and fetch of the workspace snapshot into its own layer cache and database (WorkspaceSnapshotDb). This enables us to use an Arc without extra copying when performing read-only graph operations.
Some changes were required to the blocking_commit and commit internals to ensure we perform a rebase even if no transaction has been opened in the Dal Postgres transactions state.