This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Update Components to reflect (un)deletion of Components#3468
Merged
si-bors-ng[bot] merged 4 commits intomainfrom Mar 28, 2024
Merged
Conversation
jhelwig
force-pushed
the
jhelwig/eng-2398-trigger-dvu-when-a-component-or-edge-is-deleted
branch
2 times, most recently
from
fd2123e to
a3e8eb4
Compare
jhelwig
changed the title
jhelwig
force-pushed
the
jhelwig/eng-2398-trigger-dvu-when-a-component-or-edge-is-deleted
branch
from
5de5f60 to
100c896
Compare
jobelenus
force-pushed
the
jhelwig/eng-2398-trigger-dvu-when-a-component-or-edge-is-deleted
branch
from
9bd362e to
79ebdfa
Compare
…rked as to_delete Data should be able to flow between components following the rules below: | From Component `to_delete` | To Component `to_delete` | Data Propagates | | -------------------------- | ------------------------ | --------------- | | False | False | Yes | | False | True | Yes | | True | False | No | | True | True | Yes | Whenever a Component is marked (or un-marked) as `to_delete`, we need to make sure that both its inputs, and all downstream Components' inputs are updated to reflect the rules above. This allows us to both show the effect of "deleting" a Component on the rest of the workspace, and keep data that may be necessary to perform the delete action in Components that are marked for deletion.
…ent, wip on edge restore
jhelwig
force-pushed
the
jhelwig/eng-2398-trigger-dvu-when-a-component-or-edge-is-deleted
branch
from
79ebdfa to
810520f
Compare
Removing an AttributePrototypeArgument will now cause the AttributeValue(s) that use that Prototype to automatically be updated to reflect the new function inputs.
jhelwig
force-pushed
the
jhelwig/eng-2398-trigger-dvu-when-a-component-or-edge-is-deleted
branch
from
810520f to
f7fab90
Compare
nickgerace
reviewed
Mar 27, 2024
| return new ApiRequest({ | ||
| method: "post", | ||
| url: "diagram/restore_components", | ||
| url: "diagram/remove_delete_intent", |
Comment on lines
+488
to
+489
| #[test] | ||
| async fn deletion_updates_downstream_components(ctx: &mut DalContext) { |
nickgerace
approved these changes
Mar 27, 2024
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
si-bors-ng
Bot
deleted the
jhelwig/eng-2398-trigger-dvu-when-a-component-or-edge-is-deleted
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Component inputs/outputs to reflect when a Component is (un)marked as to_delete.
Data should be able to flow between components following the rules below:
to_deleteto_deleteWhenever a Component is marked (or un-marked) as
to_delete, we need to make sure that both its inputs, and all downstream Components' inputs are updated to reflect the rules above. This allows us to both show the effect of "deleting" a Component on the rest of the workspace, and keep data that may be necessary to perform the delete action in Components that are marked for deletion.Enable delete_connection API endpoint
Removing an AttributePrototypeArgument will now cause the AttributeValue(s) that use that Prototype to automatically be updated to reflect the new function inputs.