Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

feat: add xvfb into ci-base#3481

Merged
si-bors-ng[bot] merged 1 commit intomainfrom
feat/add-cypress-coverage-target-into-buck
Mar 28, 2024
Merged

feat: add xvfb into ci-base#3481
si-bors-ng[bot] merged 1 commit intomainfrom
feat/add-cypress-coverage-target-into-buck

Conversation

@johnrwatson
Copy link
Copy Markdown
Contributor

@johnrwatson johnrwatson commented Mar 28, 2024

Adding a virtual framebuffer/a display server implementing X11 within the ci-base as there are no FE packages in there at the minute.

I imagine this might not be the final change here as we will probably need chrome or some additional browser packages for cypress.

Will work forward as needed.

Not adding into the nix flake as any normal developer machine will have this dep already satisfied

@johnrwatson
Copy link
Copy Markdown
Contributor Author

bors merge

@si-bors-ng
Copy link
Copy Markdown
Contributor

si-bors-ng Bot commented Mar 28, 2024

Build succeeded:

@si-bors-ng si-bors-ng Bot merged commit 95855b6 into main Mar 28, 2024
@si-bors-ng si-bors-ng Bot deleted the feat/add-cypress-coverage-target-into-buck branch March 28, 2024 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant