This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Annihilate all unsued migrations and queries in the dal (ENG-2435)#3494
Merged
si-bors-ng[bot] merged 1 commit intomainfrom Apr 2, 2024
Merged
Annihilate all unsued migrations and queries in the dal (ENG-2435)#3494si-bors-ng[bot] merged 1 commit intomainfrom
si-bors-ng[bot] merged 1 commit intomainfrom
Conversation
nickgerace
changed the title
This is it. Since merging the new engine onto main, we have kept around migrations and queries to help restore functionality in the system. We're now at a point where we can destroy the bulk of our old migrations and queries. You all served us well. Additional or noteworthy changes: - Move and rename all remaining queries to subdirectories based on which tables they reference - Remove dead code related to migrations and queries - Modify func-related and validation-related migrations to work since they are still used a hybrid fashion - Make FuncBinding methods private that can be made private - Fix "todo" for missing builtin workspace - Fix "get_diff" integration test final assertion Signed-off-by: Nick Gerace <nick@systeminit.com>
nickgerace
commented
Apr 2, 2024
Contributor
Author
There was a problem hiding this comment.
Remove Func and leave FuncBinding and FuncBindingReturnValue
Comment on lines
-1
to
-4
| DROP TABLE validation_prototypes CASCADE; | ||
| DELETE FROM standard_models where table_name = 'validation_prototypes'; | ||
| DROP TABLE validation_resolvers CASCADE; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
No need to drop the old tables if they are never migrated
| ADD COLUMN code_blake3 TEXT, | ||
| DROP COLUMN code_sha256; | ||
|
|
||
| DROP TABLE func_binding_belongs_to_func CASCADE; |
Contributor
Author
There was a problem hiding this comment.
This was the primary change of this file
| // We expect there to be a diff as we have changed the componentType on this changeset but HEAD is a component | ||
| assert_eq!( | ||
| Some("{\n \"si\": {\n \"color\": \"#ffffff\",\n \"name\": \"this is a new component\",\n \"type\": \"component\"\n },\n \"domain\": {\n \"name\": \"this is a new component\",\n \"possible_world_a\": {\n \"wormhole_1\": {\n \"wormhole_2\": {\n \"wormhole_3\": {}\n }\n }\n },\n \"possible_world_b\": {\n \"wormhole_1\": {\n \"wormhole_2\": {\n \"wormhole_3\": {\n \"naming_and_necessity\": \"not hesperus\"\n }\n }\n }\n },\n \"universe\": {\n \"galaxies\": []\n }\n }\n}".to_string()), // expected | ||
| Some(" {\n \"si\": {\n \"color\": \"#ffffff\",\n \"name\": \"this is a new component\",\n- \"type\": \"component\"\n+ \"type\": \"configurationFrameDown\"\n },\n \"domain\": {\n \"name\": \"this is a new component\",\n \"possible_world_a\": {\n \"wormhole_1\": {\n \"wormhole_2\": {\n \"wormhole_3\": {}\n }\n }\n },\n \"possible_world_b\": {\n \"wormhole_1\": {\n \"wormhole_2\": {\n \"wormhole_3\": {\n \"naming_and_necessity\": \"not hesperus\"\n }\n }\n }\n },\n \"universe\": {\n \"galaxies\": []\n }\n }\n }".to_string()), // expected |
Contributor
Author
There was a problem hiding this comment.
It's a bit strange that this was passing before. The new assertion is the right shape.
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is it. Since merging the new engine onto main (#3113), we have kept around migrations and queries to help restore functionality in the system. We're now at a point where we can destroy the bulk of our old migrations and queries. You all served us well.
Additional or Noteworthy Changes
FuncBindingmethods private that can be made private